[CHERRY-PICK] [Release/202311] NetworkPkg TcpDxe: Fixed system stuck on PXE boot flow in iPXE environment

[Flickdm]

Description

This bug fix is based on the following commit "NetworkPkg TcpDxe: SECURITY PATCH"
REF: 1904a64

Issue Description:
An "Invalid handle" error was detected during runtime when attempting to destroy a child instance of the hashing protocol. The problematic code segment was:

NetworkPkg\TcpDxe\TcpDriver.c
Status = Hash2ServiceBinding->DestroyChild(Hash2ServiceBinding, ​&mHash2ServiceHandle);

Root Cause Analysis:
The root cause of the error was the passing of an incorrect parameter type, a pointer to an EFI_HANDLE instead of an EFI_HANDLE itself, to the DestroyChild function. This mismatch resulted in the function receiving an invalid handle.

Implemented Solution:
To resolve this issue, the function call was corrected to pass mHash2ServiceHandle directly:

NetworkPkg\TcpDxe\TcpDriver.c
Status = Hash2ServiceBinding->DestroyChild(Hash2ServiceBinding, mHash2ServiceHandle);

This modification ensures the correct handle type is used, effectively rectifying the "Invalid handle" error.

Verification:
Testing has been conducted, confirming the efficacy of the fix. Additionally, the BIOS can boot into the OS in an iPXE environment.

Cc: Doug Flick [MSFT] [email protected]

Reviewed-by: Saloni Kasbekar [email protected]

• [ X] Impacts functionality?
  • Corrects handle passed to DestroyChild(..)
• Impacts security?
  • N/A
• Breaking change?
  • N/A
• Includes tests?
  • N/A
• Includes documentation?
  • N/A

How This Was Tested

"Testing has been conducted, confirming the efficacy of the fix. Additionally, the BIOS can boot into the OS in an iPXE environment."

iPXE booted successfully

Integration Instructions

N/A

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 1.22%. Comparing base (15c8d24) to head (590d452).

Files	Patch %	Lines
NetworkPkg/TcpDxe/TcpDriver.c	0.00%	1 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           release/202311     #879   +/-   ##
===============================================
  Coverage            1.22%    1.22%           
===============================================
  Files                1303     1303           
  Lines              335691   335691           
  Branches             3189     3189           
===============================================
  Hits                 4118     4118           
  Misses             331497   331497           
  Partials               76       76           

Flag	Coverage Δ
NetworkPkg	0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[makubacki]

Should have been marked [CHERRY-PICK] in case it goes to other branches as well.

[makubacki]

Should have been marked [CHERRY-PICK] in case it goes to other branches as well.

Also type:bug label.

[Flickdm]

Should have been marked [CHERRY-PICK] in case it goes to other branches as well.

You're right - I thought that I made that change and somehow it got dropped

I'll make sure it's on the other ones