-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UpdateConfigHdr: Gracefully exit when filepath is None
#378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`GetAbsolutePathOnThisSystemFromEdk2RelativePath` will log an error message and return `None` if absolute path could not be determined. Due to this, file should be checked against `None`, not `os.path.isfile`.
github-actions
bot
added
language:python
Pull requests that update Python code
impact:non-functional
Does not have a functional impact
labels
Jul 9, 2024
apop5
approved these changes
Jul 9, 2024
makubacki
approved these changes
Jul 9, 2024
ProjectMuBot
added a commit
to microsoft/mu_tiano_platforms
that referenced
this pull request
Jul 17, 2024
Introduces 4 new commits in [Features/CONFIG](https://github.com/microsoft/mu_feature_config.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_feature_config/commit/e87f7ca0520eb086357df22b323357d377693bc1">e87f7c</a> GitHub Action: Bump robinraju/release-downloader from 1.10 to 1.11 (<a href="https://github.com/microsoft/mu_feature_config/pull/375">#375</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/e69e758a3ead909a79260666b037899102e4b6a6">e69e75</a> UpdateConfigHdr: Gracefully exit when filepath is `None` (<a href="https://github.com/microsoft/mu_feature_config/pull/378">#378</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/3f520bb761ba428e77e3e06052ba1060aed83b3d">3f520b</a> pip: bump edk2-pytool-extensions from 0.27.6 to 0.27.8 (<a href="https://github.com/microsoft/mu_feature_config/pull/376">#376</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/c781a93b8812ea00609dac71e2f16532a43fe044">c781a9</a> pip: bump edk2-pytool-extensions from 0.27.8 to 0.27.9 (<a href="https://github.com/microsoft/mu_feature_config/pull/379">#379</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <[email protected]>
apop5
added a commit
to microsoft/mu_tiano_platforms
that referenced
this pull request
Jul 23, 2024
Bumps Features/CONFIG from `2.0.12` to `2.0.13` Introduces 4 new commits in [Features/CONFIG](https://github.com/microsoft/mu_feature_config.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_feature_config/commit/e87f7ca0520eb086357df22b323357d377693bc1">e87f7c</a> GitHub Action: Bump robinraju/release-downloader from 1.10 to 1.11 (<a href="https://github.com/microsoft/mu_feature_config/pull/375">#375</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/e69e758a3ead909a79260666b037899102e4b6a6">e69e75</a> UpdateConfigHdr: Gracefully exit when filepath is `None` (<a href="https://github.com/microsoft/mu_feature_config/pull/378">#378</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/3f520bb761ba428e77e3e06052ba1060aed83b3d">3f520b</a> pip: bump edk2-pytool-extensions from 0.27.6 to 0.27.8 (<a href="https://github.com/microsoft/mu_feature_config/pull/376">#376</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/c781a93b8812ea00609dac71e2f16532a43fe044">c781a9</a> pip: bump edk2-pytool-extensions from 0.27.8 to 0.27.9 (<a href="https://github.com/microsoft/mu_feature_config/pull/379">#379</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <[email protected]> Signed-off-by: Project Mu Bot <[email protected]> Co-authored-by: Aaron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
impact:non-functional
Does not have a functional impact
language:python
Pull requests that update Python code
type:bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GetAbsolutePathOnThisSystemFromEdk2RelativePath
will log an error message and returnNone
if absolute path could not be determined. Due to this, file should be checked againstNone
, notos.path.isfile
.You can see that in the GetAbsolutePathOnThisSystemFromEdk2RelativePath that we return a str if the absolute path is found, else
None
.Currently, when a path is not found, you get this exception and trace:
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
N/A
Integration Instructions
N/A