Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MsCorePkg: Remove invalid library instance in DSC #302

Merged

Conversation

makubacki
Copy link
Member

Description

  • GuidedSectionExtract is not a library class name.
  • GuidedSectionExtractPeim/GuidedSectionExtract.inf is a PEIM not
    a library.

This appears to be an accidental library class mapping that in any
case is confusing and ineffective.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

MsCorePkg CI build.

Integration Instructions

N/A

- `GuidedSectionExtract` is not a library class name.
- `GuidedSectionExtractPeim/GuidedSectionExtract.inf` is a PEIM not
  a library.

This appears to be an accidental library class mapping that in any
case is confusing and ineffective.

Signed-off-by: Michael Kubacki <[email protected]>
@makubacki makubacki added the type:bug Something isn't working label Aug 29, 2023
@makubacki makubacki self-assigned this Aug 29, 2023
@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Aug 29, 2023
@makubacki makubacki merged commit a814bb2 into microsoft:release/202302 Aug 29, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants