Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeQlFilters.yml: Glob file patterns in nested directories #307

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

makubacki
Copy link
Member

Description

This filter file is picked up both directly in mu_plus but also
downstream repos. Therefore, the file patterns should allow matches
regardless of where a mu_plus submodule or external dependency
may reside in the overall repo structure.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

  • Verified local mu_plus CodeQL build
  • Verified downstream (mu_tiano_platforms) CodeQL build that leverages
    the CodeQlFilters.yml file from mu_plus.

Integration Instructions

No change in filtering behavior within mu_plus. Downstream repos that use
mu_plus will see more results auto filtered matching the expectations of
upstream repos.

This filter file is picked up both directly in mu_plus but also
downstream repos. Therefore, the file patterns should allow matches
regardless of where a mu_plus submodule or external dependency
may reside in the overal repo structure.

Signed-off-by: Michael Kubacki <[email protected]>
@makubacki makubacki added type:bug Something isn't working type:enhancement New feature or pull request labels Sep 5, 2023
@makubacki makubacki self-assigned this Sep 5, 2023
@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Sep 5, 2023
@makubacki makubacki merged commit a3d53ef into microsoft:release/202302 Sep 6, 2023
30 checks passed
ProjectMuBot referenced this pull request in microsoft/mu_tiano_platforms Sep 7, 2023
Introduces 2 new commits in [Common/MU](https://github.com/microsoft/mu_plus.git).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_plus/commit/88d3dd3bf83d13bcd53146a9d5db2a922422d6e4">88d3dd</a> Repo File Sync: Add extra_cargo_steps parameter to MuDevOpsWrapper.yml (<a href="https://github.com/microsoft/mu_plus/pull/305">#305</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/a3d53ef6296bc0b1309cf2654017eb394a726dd4">a3d53e</a> CodeQlFilters.yml: Glob file patterns in nested directories (<a href="https://github.com/microsoft/mu_plus/pull/307">#307</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact type:bug Something isn't working type:enhancement New feature or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants