-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debug level prefix for advanced logger memory message entries #523
Merged
kenlautner
merged 3 commits into
microsoft:release/202311
from
liqiqiii:personal/liqiqi/dbglvlprefix
Jul 16, 2024
Merged
Add debug level prefix for advanced logger memory message entries #523
kenlautner
merged 3 commits into
microsoft:release/202311
from
liqiqiii:personal/liqiqi/dbglvlprefix
Jul 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
language:python
Pull requests that update Python code
impact:non-functional
Does not have a functional impact
labels
Jul 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202311 #523 +/- ##
===============================================
Coverage 11.04% 11.04%
===============================================
Files 144 144
Lines 22019 22019
Branches 2356 2356
===============================================
Hits 2432 2432
Misses 19555 19555
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
os-d
approved these changes
Jul 15, 2024
kenlautner
approved these changes
Jul 16, 2024
ProjectMuBot
referenced
this pull request
in microsoft/mu_tiano_platforms
Jul 17, 2024
Introduces 1 new commits in [Common/MU](https://github.com/microsoft/mu_plus.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_plus/commit/243bd187e4aa6ac68a3eb323d07554576d39ad47">243bd1</a> Add debug level prefix for advanced logger memory message entries (<a href="https://github.com/microsoft/mu_plus/pull/523">#523</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <[email protected]>
apop5
referenced
this pull request
in microsoft/mu_tiano_platforms
Jul 23, 2024
Bumps Common/MU from `2023110001.0.2` to `2023110001.0.3` Introduces 1 new commits in [Common/MU](https://github.com/microsoft/mu_plus.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_plus/commit/243bd187e4aa6ac68a3eb323d07554576d39ad47">243bd1</a> Add debug level prefix for advanced logger memory message entries (<a href="https://github.com/microsoft/mu_plus/pull/523">#523</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <[email protected]> Signed-off-by: Project Mu Bot <[email protected]> Co-authored-by: Aaron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
impact:non-functional
Does not have a functional impact
language:python
Pull requests that update Python code
type:enhancement
New feature or pull request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change added the existing metadata - debug level into the final advanced logger memory entries, it can differentiate the different debug levels, DEBUG_INFO, DEBUG_ERROR, etc.
We don't need to touch firmware as debug level info is already part of metadata, so we only need to update the decode script.
It's useful to be able to filter out the specific debug level msgs that we care about and make data processing of uefi logs possible.
For example, DEBUG_ERROR level prints are generally very important and worth analyzing. One blocking thing now is that we can't tell the difference between different debug level msgs because not all DEBUG_ERROR will have an "error:" as the prefix of the debug msg, and search for "error" will also be noisy as it's a commonly used word. After this PR checked in, we can easily track the DEBUG_ERRORs.
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
Tested with a platform that uses advancedlogger and can seedebug level prefixes in the msg.
22:36:22.840 : [MM_CORE] [DEBUG_INFO]AdvancedLoggerGetLoggerInfo: LoggerInfo=70F37000
22:36:22.857 : [MM_CORE] [DEBUG_ERROR]ERROR - The FV at 0xFFE60000 is invalid!
Integration Instructions
N/A