UefiTestingPkg: DxePagingAuditTestApp Fix Inaccessible Memory Test #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security.Misc.MemoryOutsideEfiMemoryMapIsInaccessible was failing because it was not checking the return status of ValidateRegionAttributes, which could return EFI_NO_MAPPING to indicate a given range was not in the page table. There are two independent criteria that can be satisfied to indicate that a region is inaccessible: it is marked EFI_MEMORY_RP or it is not mapped in the page table. This test was only checking the first case and not the second case. With this update it now correctly checks both cases.
github-actions
bot
added
impact:non-functional
makubacki
approved these changes
Jul 23, 2024
apop5
approved these changes
Jul 23, 2024
os-d
added a commit
to os-d/mu_tiano_platforms
that referenced
this pull request
Jul 23, 2024
The DxePagingAuditTestApp was failing on all architectures because of a misimplementation. That was fixed in microsoft/mu_plus#528. This patch pulls in the newer mu_plus to get that change and drops the exemption from Q35 and SBSA.
5 tasks
os-d
added a commit
to os-d/mu_tiano_platforms
that referenced
this pull request
Jul 23, 2024
The DxePagingAuditTestApp was failing on all architectures because of a misimplementation. That was fixed in microsoft/mu_plus#528. This patch pulls in the newer mu_plus to get that change and drops the exemption from Q35 and SBSA.
os-d
added a commit
to microsoft/mu_tiano_platforms
that referenced
this pull request
Jul 23, 2024
## Description The DxePagingAuditTestApp was failing on all architectures because of a misimplementation. That was fixed in microsoft/mu_plus#528. This patch pulls in the newer mu_plus to get that change and drops the exemption from Q35 and SBSA. - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [x] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested Ran paging audit test and it succeeds. ## Integration Instructions N/A.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Security.Misc.MemoryOutsideEfiMemoryMapIsInaccessible was failing because it was not checking the return status of
ValidateRegionAttributes, which could return EFI_NO_MAPPING to indicate a given range was not in the page table. There are two independent criteria that can be satisfied to indicate that a region is inaccessible: it is marked EFI_MEMORY_RP or it is not mapped in the page table. This test was only checking the first case and not the second case. With this update it now correctly checks both cases.
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
Tested on Q35 and saw that the formerly failing test is now passing.
Integration Instructions
N/A.