Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move MockDeviceBootManagerLib Path #584

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

YiTa-AMI
Copy link
Contributor

Description

Change PR572 MockDeviceBootManagerLib Path to match Guideline

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Unit tests component can call these mock functions success

Integration Instructions

N/A

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Sep 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.40%. Comparing base (1817ee0) to head (2cd6892).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/202405     #584   +/-   ##
===========================================
  Coverage       11.40%   11.40%           
===========================================
  Files             145      145           
  Lines           21915    21915           
  Branches         2546     2546           
===========================================
  Hits             2499     2499           
  Misses          19382    19382           
  Partials           34       34           
Flag Coverage Δ
MfciPkg 39.37% <ø> (ø)
MsCorePkg 1.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YiTa-AMI YiTa-AMI marked this pull request as ready for review September 26, 2024 13:17
@apop5 apop5 requested a review from VivianNK September 26, 2024 15:40
Copy link
Contributor

@VivianNK VivianNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add GoogleTest as a folder.

E.g.
https://github.com/microsoft/mu_basecore/pull/1162/files
So instead of MsCorePkg/Test/Mock/Library/MockDeviceBootManagerLib/MockDeviceBootManagerLib.cpp -> MsCorePkg/Test/Mock/Library/GoogleTest/MockDeviceBootManagerLib/MockDeviceBootManagerLib.cpp

@YiTa-AMI YiTa-AMI force-pushed the MoveMockLibraryPath branch 2 times, most recently from 6ad1502 to 0f71656 Compare September 27, 2024 05:52
@YiTa-AMI
Copy link
Contributor Author

Please add GoogleTest as a folder.

E.g. https://github.com/microsoft/mu_basecore/pull/1162/files So instead of MsCorePkg/Test/Mock/Library/MockDeviceBootManagerLib/MockDeviceBootManagerLib.cpp -> MsCorePkg/Test/Mock/Library/GoogleTest/MockDeviceBootManagerLib/MockDeviceBootManagerLib.cpp

Moved

@YiTa-AMI
Copy link
Contributor Author

YiTa-AMI commented Oct 7, 2024

Hi @VivianNK
Would you kindly help check is other change need to do?

@YiTa-AMI YiTa-AMI requested a review from VivianNK October 7, 2024 09:24
@VivianNK VivianNK merged commit 2ae00d1 into microsoft:dev/202405 Oct 7, 2024
28 checks passed
@YiTa-AMI YiTa-AMI deleted the MoveMockLibraryPath branch October 8, 2024 06:08
VivianNK pushed a commit to VivianNK/mu_plus that referenced this pull request Oct 25, 2024
## Description

Change PR572 MockDeviceBootManagerLib Path to match Guideline

For details on how to complete these options and their meaning refer to
[CONTRIBUTING.md](https://github.com/microsoft/mu/blob/HEAD/CONTRIBUTING.md).

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?

## How This Was Tested

Unit tests component can call these mock functions success

## Integration Instructions

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants