-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move MockDeviceBootManagerLib Path #584
Conversation
517851f
to
af180c4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #584 +/- ##
===========================================
Coverage 11.40% 11.40%
===========================================
Files 145 145
Lines 21915 21915
Branches 2546 2546
===========================================
Hits 2499 2499
Misses 19382 19382
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add GoogleTest as a folder.
E.g.
https://github.com/microsoft/mu_basecore/pull/1162/files
So instead of MsCorePkg/Test/Mock/Library/MockDeviceBootManagerLib/MockDeviceBootManagerLib.cpp
-> MsCorePkg/Test/Mock/Library/GoogleTest/MockDeviceBootManagerLib/MockDeviceBootManagerLib.cpp
6ad1502
to
0f71656
Compare
Moved |
0f71656
to
fddcbd7
Compare
fddcbd7
to
2cd6892
Compare
Hi @VivianNK |
## Description Change PR572 MockDeviceBootManagerLib Path to match Guideline For details on how to complete these options and their meaning refer to [CONTRIBUTING.md](https://github.com/microsoft/mu/blob/HEAD/CONTRIBUTING.md). - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Unit tests component can call these mock functions success ## Integration Instructions N/A
Description
Change PR572 MockDeviceBootManagerLib Path to match Guideline
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
Unit tests component can call these mock functions success
Integration Instructions
N/A