Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MfciPolicy.py syntax error #606

Merged

Conversation

MarcChen46
Copy link
Contributor

@MarcChen46 MarcChen46 commented Oct 29, 2024

Description

Fix a syntax error in MfciPolicy.py while using pyinstaller to generate executable file.
image

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Verified the MfciPolicy.exe can be generated by pyinstaller successfully.
Verified the system info can be dumped as below
image

Integration Instructions

N/A

@github-actions github-actions bot added language:python Pull requests that update Python code impact:non-functional Does not have a functional impact labels Oct 29, 2024
@MarcChen46
Copy link
Contributor Author

@apop5 @kuqin12

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.40%. Comparing base (5ce0d6a) to head (4c17aae).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/202405     #606   +/-   ##
===========================================
  Coverage       11.40%   11.40%           
===========================================
  Files             145      145           
  Lines           21915    21915           
  Branches         2546     2546           
===========================================
  Hits             2499     2499           
  Misses          19382    19382           
  Partials           34       34           
Flag Coverage Δ
MfciPkg 39.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuqin12 kuqin12 enabled auto-merge (squash) October 30, 2024 00:25
@kuqin12 kuqin12 merged commit cda7aec into microsoft:dev/202405 Oct 30, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact language:python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants