Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update basecore and supervisor submodules #1025

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

kuqin12
Copy link
Contributor

@kuqin12 kuqin12 commented Aug 28, 2024

Description

Update mu_basecore to top of release/202405 and supervisor repo to pair up with the updated override tags.

For details on how to complete to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Tested on QEMU Q35 and booted to shell.

Integration Instructions

N/A

@kuqin12 kuqin12 enabled auto-merge (squash) August 28, 2024 22:56
@Javagedes
Copy link
Contributor

Javagedes commented Aug 29, 2024

My most recent change to ImageValidation plugin that this submodule update brought in fixed the fact that the plugin was skipping verification off all binaries on a CLANGPDB toolchain build; however it looks like the pefile pypi project is having issues with parsing one (or maybe all) of the pecoffs generated via CLANGPDB. I will investigate.

@Javagedes
Copy link
Contributor

Javagedes commented Aug 29, 2024

PR365 that went into pefile for release 2024.8.26 is the culprit. . It is failing to parse XhciDxe.efi. I will post a bug there and provide XhciDxe.efi in it. I can work around this issue by not doing a full load of the PE file, which I will post a PR for. But it is still a bug that needs to be reported with pefile.

File "C:\Users\joeyvagedes\.virtualenvs\mu_tiano_platforms-hKhfHhJg\Lib\site-packages\pefile.py", line 4601, in parse_debug_directory
    dbg_type.ExDllCharacteristics,
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'ExDllCharacteristics'

Edit: Issue posted erocarrera/pefile#421

Javagedes added a commit to microsoft/mu_basecore that referenced this pull request Aug 29, 2024
## Description

This commit modifies the PE parsing functionality to only parse the
headers of the image, rather than the entire image. This change is made
to improve performance and also the probability of failing to parse the
entire image. This comes after this commit
(erocarrera/pefile#365) in pefile resulted in
efi image parsing failures, breaking the build.

This commit also wraps the parsing of the image in a try-except block to
catch any exceptions that may be raised during parsing, to cleanly exit.

See: microsoft/mu_tiano_platforms#1025 and
erocarrera/pefile#421

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?

## How This Was Tested

Validated pipelines build on mu_tiano_platforms

## Integration Instructions

N/A
@kuqin12 kuqin12 merged commit 1fa16a6 into microsoft:main Aug 29, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants