Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Rust HID driver #738

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

makubacki
Copy link
Member

Description

Per integration instructions in microsoft/mu_plus#324,
UsbMouseAbsolutePointerDxe is removed and UsbHidDxe and UefiHidDxe are
added to the build.

The absolute pointer protocol will now be installed by the AbsolutePointer
crate in HidPkg linked against the UefiHidDxe module.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

  • Verified QemuQ35Pkg and QemuSbsaPkg build and boot to EFI shell

Integration Instructions

N/A

@github-actions github-actions bot added the language:python Pull requests that update Python code label Oct 17, 2023
@makubacki
Copy link
Member Author

This is in draft state and will not boot until microsoft/mu_plus#334 is completed.

@github-actions github-actions bot removed the language:python Pull requests that update Python code label Oct 17, 2023
@makubacki
Copy link
Member Author

This is in draft state and will not boot until microsoft/mu_plus#334 is completed.

mu_plus submodule updated

@makubacki makubacki marked this pull request as ready for review October 17, 2023 23:08
@makubacki makubacki self-assigned this Oct 17, 2023
@makubacki makubacki added the type:enhancement New feature or pull request label Oct 17, 2023
Per integration instructions in microsoft/mu_plus#324,
`UsbMouseAbsolutePointerDxe` is removed and `UsbHidDxe` and `UefiHidDxe` are
added to the build.

The absolute pointer protocol will now be installed by the `AbsolutePointer`
crate in `HidPkg` linked against the `UefiHidDxe` module.

r-efi is updated to v4.3.0 to pick up the absolute pointer protocol definition
added in that release.

Signed-off-by: Michael Kubacki <[email protected]>
@makubacki
Copy link
Member Author

Latest push picked up the most recent Mu Plus release (v2023020002.0.4) and r-efi v4.3.0 which reflects the way the absolute pointer protocol is used in that release.

@makubacki makubacki enabled auto-merge (squash) October 18, 2023 23:41
@makubacki makubacki merged commit a14c24e into microsoft:main Oct 19, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants