Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Additional SSE Instructions to Q35 #957

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

os-d
Copy link
Contributor

@os-d os-d commented May 20, 2024

Description

SSE 4.1 and 4.2 support was added to Q35 in order to support more recent Windows versions that require it. However, this broke recent Linux versions, which saw the 4.1 and 4.2 support and assumed other SSE support, which was not there. This adds all SSE instruction sets to Q35 to support both Linux and Windows.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Booted both a formerly failing Linux and Windows to confirm both boot.

Integration Instructions

N/A.

@github-actions github-actions bot added language:python Pull requests that update Python code impact:non-functional Does not have a functional impact labels May 20, 2024
@makubacki makubacki added the type:bug Something isn't working label May 20, 2024
@makubacki
Copy link
Member

Added the bug label to bring attention that this might fix problems in the release notes.

@os-d
Copy link
Contributor Author

os-d commented May 20, 2024

Added the bug label to bring attention that this might fix problems in the release notes.

Thanks, sorry I forgot to do that again.

@os-d os-d enabled auto-merge (squash) May 20, 2024 23:46
@os-d os-d merged commit 2b05776 into microsoft:main May 21, 2024
27 checks passed
@os-d os-d deleted the osde/sse_linux branch May 21, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact language:python Pull requests that update Python code type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants