Add an assert to TCG log function if log is full #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os-d
reviewed
Mar 20, 2024
os-d
approved these changes
Mar 20, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202311 #257 +/- ##
=================================================
- Coverage 1.42% 0.99% -0.44%
=================================================
Files 155 155
Lines 36454 36400 -54
Branches 265 265
=================================================
- Hits 521 361 -160
+ Misses 35933 35931 -2
- Partials 0 108 +108
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
apop5
approved these changes
Mar 20, 2024
ProjectMuBot
referenced
this pull request
in microsoft/mu_tiano_platforms
Mar 23, 2024
Introduces 4 new commits in [Common/MU_TIANO](https://github.com/microsoft/mu_tiano_plus.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/f32fecfb4badf005ccda509aa1d8a7128bed1506">f32fec</a> pip: bump edk2-pytool-extensions from 0.27.2 to 0.27.3 (<a href="https://github.com/microsoft/mu_tiano_plus/pull/251">#251</a>)</li> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/e8e47a1b2dd4fc4cd948dd5f430617f5fde21ab6">e8e47a</a> pip: bump edk2-pytool-library from 0.21.3 to 0.21.4 (<a href="https://github.com/microsoft/mu_tiano_plus/pull/255">#255</a>)</li> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/e28c7a52ee349d2539bf2dc49208b6b20ac2fead">e28c7a</a> Repo File Sync: prevent `rustup` from self-updating (<a href="https://github.com/microsoft/mu_tiano_plus/pull/256">#256</a>)</li> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/1c115e608362accbb38bb091aa006e5392a57ea4">1c115e</a> Add an assert to TCG log function if log is full (<a href="https://github.com/microsoft/mu_tiano_plus/pull/257">#257</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <[email protected]>
kuqin12
referenced
this pull request
in microsoft/mu_tiano_platforms
Apr 4, 2024
Bumps Common/MU_TIANO from `2023110000.0.4` to `2023110000.0.5` Introduces 4 new commits in [Common/MU_TIANO](https://github.com/microsoft/mu_tiano_plus.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/f32fecfb4badf005ccda509aa1d8a7128bed1506">f32fec</a> pip: bump edk2-pytool-extensions from 0.27.2 to 0.27.3 (<a href="https://github.com/microsoft/mu_tiano_plus/pull/251">#251</a>)</li> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/e8e47a1b2dd4fc4cd948dd5f430617f5fde21ab6">e8e47a</a> pip: bump edk2-pytool-library from 0.21.3 to 0.21.4 (<a href="https://github.com/microsoft/mu_tiano_plus/pull/255">#255</a>)</li> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/e28c7a52ee349d2539bf2dc49208b6b20ac2fead">e28c7a</a> Repo File Sync: prevent `rustup` from self-updating (<a href="https://github.com/microsoft/mu_tiano_plus/pull/256">#256</a>)</li> <li><a href="https://github.com/microsoft/mu_tiano_plus/commit/1c115e608362accbb38bb091aa006e5392a57ea4">1c115e</a> Add an assert to TCG log function if log is full (<a href="https://github.com/microsoft/mu_tiano_plus/pull/257">#257</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <[email protected]> Signed-off-by: Project Mu Bot <[email protected]> Co-authored-by: Aaron <[email protected]> Co-authored-by: kuqin12 <[email protected]>
cfernald
added a commit
to cfernald/mu_tiano_plus
that referenced
this pull request
Jul 20, 2024
Currently, if the TCG log fills up, the firmware will boot only logging some errors and the OS may or may not fail depending on scenario and configuration. This PR adds an assert so that these truncations can be found in testing rather then having to wait for failures in production. - [X] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? N/A N/A cherry-pick from 1c115e6
cfernald
added a commit
to cfernald/mu_tiano_plus
that referenced
this pull request
Jul 22, 2024
Currently, if the TCG log fills up, the firmware will boot only logging some errors and the OS may or may not fail depending on scenario and configuration. This PR adds an assert so that these truncations can be found in testing rather then having to wait for failures in production. - [X] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? N/A N/A cherry-pick from 1c115e6
cfernald
added a commit
to cfernald/mu_tiano_plus
that referenced
this pull request
Jul 22, 2024
Currently, if the TCG log fills up, the firmware will boot only logging some errors and the OS may or may not fail depending on scenario and configuration. This PR adds an assert so that these truncations can be found in testing rather then having to wait for failures in production. - [X] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? N/A N/A cherry-pick from 1c115e6
cfernald
added a commit
to cfernald/mu_tiano_plus
that referenced
this pull request
Jul 22, 2024
Currently, if the TCG log fills up, the firmware will boot only logging some errors and the OS may or may not fail depending on scenario and configuration. This PR adds an assert so that these truncations can be found in testing rather then having to wait for failures in production. - [X] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? N/A N/A cherry-pick from 1c115e6
cfernald
added a commit
to cfernald/mu_tiano_plus
that referenced
this pull request
Jul 22, 2024
Currently, if the TCG log fills up, the firmware will boot only logging some errors and the OS may or may not fail depending on scenario and configuration. This PR adds an assert so that these truncations can be found in testing rather then having to wait for failures in production. - [X] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? N/A N/A cherry-pick from 1c115e6
cfernald
added a commit
to cfernald/mu_tiano_plus
that referenced
this pull request
Jul 23, 2024
Currently, if the TCG log fills up, the firmware will boot only logging some errors and the OS may or may not fail depending on scenario and configuration. This PR adds an assert so that these truncations can be found in testing rather then having to wait for failures in production. - [X] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? N/A N/A cherry-pick from 1c115e6
cfernald
added a commit
to cfernald/mu_tiano_plus
that referenced
this pull request
Jul 23, 2024
Currently, if the TCG log fills up, the firmware will boot only logging some errors and the OS may or may not fail depending on scenario and configuration. This PR adds an assert so that these truncations can be found in testing rather then having to wait for failures in production. - [X] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? N/A N/A cherry-pick from 1c115e6
cfernald
added a commit
to cfernald/mu_tiano_plus
that referenced
this pull request
Jul 23, 2024
…oft#257) Currently, if the TCG log fills up, the firmware will boot only logging some errors and the OS may or may not fail depending on scenario and configuration. This PR adds an assert so that these truncations can be found in testing rather then having to wait for failures in production. - [X] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? N/A N/A cherry-pick from 1c115e6 Signed-off-by: Chris Fernald <[email protected]>
cfernald
added a commit
that referenced
this pull request
Jul 23, 2024
Currently, if the TCG log fills up, the firmware will boot only logging some errors and the OS may or may not fail depending on scenario and configuration. This PR adds an assert so that these truncations can be found in testing rather then having to wait for failures in production. - [X] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? N/A N/A cherry-pick from 1c115e6 Signed-off-by: Chris Fernald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, if the TCG log fills up, the firmware will boot only logging some errors and the OS may or may not fail depending on scenario and configuration. This PR adds an assert so that these truncations can be found in testing rather then having to wait for failures in production.
How This Was Tested
N/A
Integration Instructions
N/A