This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Fix bug: GPUs are not released in Reusable Training Service #3941
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
trial.environment
is first released, it is alwaysundefined
.nni/ts/nni_manager/training_service/reusable/trialDispatcher.ts
Lines 734 to 746 in 5eb43ea
The
gpuScheduler
will never release it because it requirestrial.environment !== undefined
nni/ts/nni_manager/training_service/reusable/gpuScheduler.ts
Lines 99 to 104 in 5eb43ea
To fix this bug,
this.gpuScheduler.removeGpuReservation(trial)
should be executed at the beginning ofreleaseEnvironment