Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README #47

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Improve README #47

merged 2 commits into from
Oct 25, 2021

Conversation

Marcono1234
Copy link
Contributor

@Marcono1234 Marcono1234 commented Aug 29, 2021

  • Add missing type definition for JSONPath; matching the content of src/main.ts
  • Consistently use 4 spaces as indentation for code blocks

@ghost
Copy link

ghost commented Aug 29, 2021

CLA assistant check
All CLA requirements met.

@@ -172,6 +172,7 @@ export declare function stripComments(text: string, replaceCh?: string): string;
export declare function getLocation(text: string, position: number): Location;

export declare type Segment = string | number;
export declare type JSONPath = Segment[];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not completely sure if declare is needed here; the README does not seem to use it consistently.

@aeschli aeschli merged commit 81825b0 into microsoft:main Oct 25, 2021
@aeschli aeschli self-assigned this Oct 25, 2021
@aeschli aeschli added this to the October 2021 milestone Oct 25, 2021
@aeschli
Copy link
Contributor

aeschli commented Oct 25, 2021

Thanks a lot, @Marcono1234 !

@Marcono1234 Marcono1234 deleted the patch-1 branch October 25, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants