Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host conout socket in a worker #415

Merged
merged 6 commits into from
Feb 9, 2021
Merged

Host conout socket in a worker #415

merged 6 commits into from
Feb 9, 2021

Commits on Jun 9, 2020

  1. Host conout socket in a worker

    Conpty can send a final screen update after ClosePseudoConsole which waits for the socket
    to be drained before continuing. When both the socket draining and closing occurs on the
    same thread a deadlock can occur which locks up VS Code's UI, the only ways to fix are
    to close the client or kill the misbehaving conhost instance. This change moves the
    handling of the conout named pipe to a Worker which bumps the minimum Node version
    requirement to 12 (10 with a flag). This change may also have positive performance
    benefits as called out in microsoft/vscode#74620
    
    The worker change also happens for winpty, it seems to work there too.
    
    Fixes #375
    Tyriar committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    e430d82 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6da48b0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a8d2b41 View commit details
    Browse the repository at this point in the history
  4. Update pipelines Node version

    Tyriar committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    ab5b172 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2020

  1. Add min version for Electron

    Tyriar committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    3d299ba View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. Configuration menu
    Copy the full SHA
    dcc96be View commit details
    Browse the repository at this point in the history