Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Startup file setting breaks debugger #66

Closed
mousetraps opened this issue Apr 13, 2015 · 3 comments · Fixed by #153
Closed

Startup file setting breaks debugger #66

mousetraps opened this issue Apr 13, 2015 · 3 comments · Fixed by #153
Assignees
@mousetraps
Labels
bug in-progress
Milestone
May 2015

Comments

@mousetraps
Copy link
Contributor

If you specify your startup file under the Node.exe arguments setting, the debugger does not start.

(copied from https://nodejstools.codeplex.com/workitem/1862)
@mousetraps mousetraps added the bug label Apr 13, 2015
@mousetraps
Copy link
Contributor Author

We should make sure we are prepending --debug-brk to the arguments, and maybe even consider overriding the startup arguments altogether when node.exe arguments are passed.

@kdelmonte
Copy link

Bump.

@mousetraps mousetraps self-assigned this May 5, 2015
@mousetraps mousetraps added this to the May milestone May 5, 2015
@mousetraps
Copy link
Contributor Author

Brain-dumping a bit... I looked into this a little further. The problem with simply re-arranging the arguments is that it breaks process.argv because you might have an additional argument present. The solution I'm planning is:

  • rename "Node.exe arguments" -> "Node.exe options" to be consistent with node --help
  • rearrange arguments so that they are in order that they are appended to one another:
    • Node.exe
    • Node.exe options
    • [new] script (startup file) - this surfaces up the startup file so that it is visible and you can edit it from project properties, but it doesn't block right clicking the file and setting as startup file.
    • script arguments

@mousetraps mousetraps mentioned this issue Jun 1, 2015
Merged
mousetraps added a commit to mousetraps/nodejstools that referenced this issue Jun 1, 2015
@mousetraps
Fix startup file issues
ced4dc1 
Fix microsoft#66 startup file setting breaks debugger
- rename "Node.exe arguments" -> "Node.exe options" to be consistent with
  node --help
- rearrange arguments so that they are in the order they are supposed to
  be appended to one another
- create a new "script (startup file)" property so that it is visible
  what arguments are getting passed to node from the General properties
  page, and doesn't block right clicking the file and setting as startup
  file or modifying it from file properties.

Fix microsoft#65 Enable "Set as Node.js Startup File" context menu item for all
filetypes
- add a special case for when there is no exension specified, as is the
  case in the default express 4 template.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mousetraps mousetraps

Labels
bug in-progress
Projects
None yet
Milestone
May 2015
Development

Successfully merging a pull request may close this issue.

Fix startup file issues mousetraps/nodejstools
2 participants
@mousetraps @kdelmonte