Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"com.microsoft.onnxruntime_extensions" is not a valid bundle identifier #825

Open
ronyfadel opened this issue Oct 13, 2024 · 4 comments
Open

"com.microsoft.onnxruntime_extensions" is not a valid bundle identifier #825

ronyfadel opened this issue Oct 13, 2024 · 4 comments

Comments

@ronyfadel
Copy link
Contributor

the exported framework has a bundle identifier of "com.microsoft.onnxruntime_extensions", which is invalid (because of the "_") and Xcode is starting to reject it.
@wenbingl
Copy link
Member

@edgchen1 , any suggestions?

@edgchen1
Copy link
Contributor

@edgchen1 , any suggestions?

maybe rename it to "com.microsoft.onnxruntime-extensions".

https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleidentifier?language=objc

ronyfadel added a commit to ronyfadel/onnxruntime-extensions that referenced this issue Oct 21, 2024
@ronyfadel
Change the framework bundle identifier to a valid one
3ea0611 
Ref: microsoft#825

"com.microsoft.onnxruntime_extensions" is not a valid identifier. Update it to "com.microsoft.onnxruntime-extensions"
@ronyfadel ronyfadel mentioned this issue Oct 21, 2024
Merged
@ronyfadel
Copy link
Contributor Author

#829

wenbingl pushed a commit that referenced this issue Oct 21, 2024
@ronyfadel
Change the framework bundle identifier to a valid one (#829)
8de0d6c 
Ref: #825

"com.microsoft.onnxruntime_extensions" is not a valid identifier. Update it to "com.microsoft.onnxruntime-extensions"
@ronyfadel
Copy link
Contributor Author

@edgchen1 @wenbingl can we create a new release please, both here and in https://github.com/microsoft/onnxruntime-swift-package-manager ?

The issues will start piling up soon as this breaks the package in Xcode 16.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ronyfadel @wenbingl @edgchen1