Add an environment variable to explicitly enable/disable azureop build #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wenbingl
commented
Aug 16, 2023
•
wenbingl
commented
- Add two env. variable to control the azureop build.
- Add two pipelines to verify the debuggable and editable python build. + some minor fixes.
wenbingl
changed the title
| if azure_flag is None: | ||
| # OCOS_NO_AZURE will be ignored if OCOS_ENABLE_AZURE is set. | ||
| azure_flag = "OFF" if os.environ.get('OCOS_NO_AZURE') == '1' else None | ||
| if azure_flag is not None: |
There was a problem hiding this comment.
No else, and it's intentional. if user set flag, cmake can have the option, otherwise the value will be the cmake default value.
sayanshaw24
approved these changes
Aug 17, 2023
RandySheriffH
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.