Make Azure op timeout an attribute #539
Conversation
…bitrary) value of 15 seconds.
Update test model to validate timeout is read correctly.
| @@ -66,6 +66,7 @@ def make_graph(*args, doc_string=None, **kwargs): | |||
| audio_format='wav', # default audio type if filename is not specified. | |||
| model_uri='https://api.openai.com/v1/audio/transcriptions', | |||
| model_name='whisper-1', | |||
| timeout_seconds=20, | |||
There was a problem hiding this comment.
would you consider to make time_out be an input, so it may let the user set time-out on-the-fly according to the different network?
There was a problem hiding this comment.
we can consider it. I'd like to keep things simple until we figure out what exactly is required though.
the attribute provides a default - easily viewed but set at model creation time.
we can also make the custom op look for an input with the same suffix as the attribute providing a runtime value (this is already supported - something like 'nodeX/timeout_seconds' provides the 'timeout_seconds' value so nodes with the same custom op can have different timeouts).
that input can also be backed by an initializer with the same name (makes it an optional graph input) so the value is configurable but not mandatory to be provided by the user.
Make timeout an attribute with default if not specified.
Set default to 15s (arbitrary - can change if there's a preferred value).