-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix extensions nuget pipeline #629
Conversation
YUNQIUGUO
commented
Jan 4, 2024
- successful build: https://aiinfra.visualstudio.com/Lotus/_build/results?buildId=394396&view=results
@@ -122,6 +125,7 @@ jobs: | |||
|
|||
- script: | | |||
ORT_EXTENSIONS_LOCAL_POD_PATH=$(Build.BinariesDirectory)/pod_staging \ | |||
EXCLUDE_MACOS_TARGET=true \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of interest if we don't build the macos frameworks, why do we need to explicitly exclude them?
that seems like it will be a painful experience if someone is trying to do a local build with a subset of platforms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in our current test app setup, the Podfile by default will include both macos/ios testing targets so we can share one single testing app.
And specifying this variable is just to let the CI test project pass if MacOS arch not included in the current build /using a subset of platforms
If a user doing a local build with their own project with correctly specified supported platform sets in the Podfile, wouldn't need to explicitly setting this variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more natural way would be I can modify to include_macos_target
if we build for macos:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a comment to the script for pod install
with this info?
something along the lines of 'we exclude macos in the build_framework.py command in this CI but the test app's podfile is setup for all platforms, and due to that we have to explicitly exclude the macos target when installing the pod for the test app'. not sure that's completely accurate so please adjust as needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I added a note. also added for another place in CI.yml file for the case where we only build for a subset of platforms.
…sions into yguo/fix-extensions-nuget-pipeline
…om/microsoft/onnxruntime-extensions into yguo/fix-extensions-nuget-pipeline