make onnx package to be optional. #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayanshaw24
previously approved these changes
Feb 15, 2024
| @@ -37,10 +114,10 @@ def get_opset_version_from_ort(): | |||
| "1.12": 17, | |||
| "1.13": 17, | |||
| "1.14": 18, | |||
| "1.15": 18 | |||
| "1.15": 18, | |||
There was a problem hiding this comment.
nit: why the comma here?
There was a problem hiding this comment.
VS code formatter did it. no sure why it is
sayanshaw24
approved these changes
Feb 15, 2024
YUNQIUGUO
pushed a commit
that referenced
this pull request
Feb 16, 2024
* putting onnx package to be optional * update the ci.yml * add more message of missing ONNX package
YUNQIUGUO
added a commit
that referenced
this pull request
Feb 16, 2024
* support python 3.12 for packaging pipeline (#650) * support python 3.12 for packaging pipeline * turn unit test build off for python package * update ctest flag for selected_ops build * make onnx package to be optional. (#653) * putting onnx package to be optional * update the ci.yml * add more message of missing ONNX package --------- Co-authored-by: Wenbing Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ONNX dependency is only used on offline model generation, so make it be optional to remove the dependency on building ort-extensions package.