-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom ops ReplaceZero #739
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider
- format the code
- add a few more details. (1) how to run this test, (2) kernel selection mechanism to explain why you define two kernels for fp16 and fp32.
- avoid abbreviations as function name.
Please ping me when you want me to review again. Thanks. |
I chose cvt for convert, I thought it was a common abbrevation. I replaced by cast. For float32, float16, we can extend to bfloat16 if needed. I chose not to reduce compilation time but we definitly can add it. What do you mean by how to run the unit tests? There is one file associated to all the kernel implemented in that folder: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.