-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the pipeline breaks dues to the MSVC 19.40 and numpy 2.0 release #747
Conversation
@snnn any idea why the following command line doesn't work 2024-06-14T23:22:52.1858496Z "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe" -S D:\a_work\1\s -B .scb\temp.win-amd64-cpython-312\Release -DCMAKE_LIBRARY_OUTPUT_DIRECTORY=D:\a_work\1\s.scb\lib.win-amd64-cpython-312\onnxruntime_extensions -DOCOS_ENABLE_CTEST=OFF -DOCOS_BUILD_PYTHON=ON -DOCOS_PYTHON_MODULE_PATH=D:\a_work\1\s.scb\lib.win-amd64-cpython-312\onnxruntime_extensions_extensions_pydll.cp312-win_amd64.pyd -DCMAKE_BUILD_TYPE=Release -DOCOS_USE_CUDA=ON "-T cuda=D:\a_work_temp\v11.8" -DCMAKE_CUDA_FLAGS_INIT=--allow-unsupported-compiler -DCMAKE_CUDA_ARCHITECTURES=70;86 |
Use the latest cmake |
Remove "python -m pip install cmake" |
The machine already has cmake |
Do not use
|
I deleted one of the cmake from the VM image. Then one of the failed pipelines passed. |
Why is there no C:\program files\cmake... in CUDA Windows machine? |
It shouldn't. Could you give me a link of the log? |
There is no direct log. Python code detected ProgramFiles/CMake firstly then falled back to VS/cmake. In this log, https://dev.azure.com/onnxruntime/onnxruntime/_build/results?buildId=1409852&view=logs&j=1130dc32-b83a-5b28-25cb-8e5ca42e48d6&t=524fdcc1-2f40-5737-3487-03bf6009139b, it did fallback to vs/cmake. |
Hi @wenbingl , CMake 3.30 is failing with this PR due to this line: onnxruntime-extensions/CMakeLists.txt Line 41 in 3b275b1
I think it's because it's missing SET argument in cmake_policy. Is it possible to fix it? Thanks! |
Thanks for the reporting, here is the fixing: #754 |
inspired by this PR: microsoft/onnxruntime#21004