Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several C5038 warnings #748

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

skyline75489
Copy link
Collaborator

  • warning C5038: data member 'ort_extensions::ImageProcessor::allocator_' will be initialized after base class 'OrtxObjectImpl'
  • warning C5038: data member 'ort_extensions::OrtxRunner::allocator_' will be initialized after data member 'ort_extensions::OrtxRunner::ops_'

@skyline75489 skyline75489 requested a review from a team as a code owner June 19, 2024 04:01
@wenbingl
Copy link
Member

/azp run onnxruntime-extensions.CI

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wenbingl
Copy link
Member

  • warning C5038: data member 'ort_extensions::ImageProcessor::allocator_' will be initialized after base class 'OrtxObjectImpl'
  • warning C5038: data member 'ort_extensions::OrtxRunner::allocator_' will be initialized after data member 'ort_extensions::OrtxRunner::ops_'

Thanks for the fixing,

How do you find this issue? From https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/c5038?view=msvc-170, the warning is off by default.

@skyline75489
Copy link
Collaborator Author

Suggested by Changming, ORT uses /WX, which treats all warnings as errors. In ort-genai, we try to accomplish the same

@skyline75489 skyline75489 merged commit 58b5523 into microsoft:main Jun 20, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants