Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QNN EP] Update to QNN SDK 2.24.0 #21463

Merged
merged 9 commits into from
Jul 24, 2024
Merged

[QNN EP] Update to QNN SDK 2.24.0 #21463

merged 9 commits into from
Jul 24, 2024

Conversation

adrianlizarraga
Copy link
Contributor

@adrianlizarraga adrianlizarraga commented Jul 23, 2024 •
edited
Loading

Description

  • Update pipelines to use QNN SDK 2.24 by default
  • Update QNN_Nuget_Windows pipeline to build csharp solution without mobile projects (fixes errors).
  • Implement workaround for QNN 2.24 validation bug for LayerNorm ops without an explicit bias input.
  • Enable Relu unit test, which now passes due to the fact Relu is no longer fused into QuantizeLinear for QNN EP.
  • Fix bug where a negative quantization axis is not properly normalized for per-channel int4 conv.

Motivation and Context

Update QNN SDk.

@adrianlizarraga adrianlizarraga added the ep:QNN issues related to QNN exeution provider label Jul 23, 2024
jywu-msft
jywu-msft previously approved these changes Jul 24, 2024
View reviewed changes
@adrianlizarraga adrianlizarraga marked this pull request as ready for review July 24, 2024 02:15
@adrianlizarraga adrianlizarraga requested a review from a team as a code owner July 24, 2024 02:15
@adrianlizarraga adrianlizarraga merged commit eb9b377 into main Jul 24, 2024
99 checks passed
@adrianlizarraga adrianlizarraga deleted the adrianl/qnn-sdk-2.24 branch July 24, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywu-msft jywu-msft jywu-msft approved these changes

@HectorSVC HectorSVC Awaiting requested review from HectorSVC

Assignees
No one assigned
Labels
ep:QNN issues related to QNN exeution provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrianlizarraga @jywu-msft