Support symbolic dimension in Scan subgraph outputs #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the output has a symbolic dimension
* Infer the shape if it is a loop state variable as we have the input value, and the shape from the subgraph output must match
* Use a temporary MLValue for the first subgraph execution if it is a subgraph output with a symbolic dimension.
* After the first execution make the overall output shape concrete and allocate the full output buffer.
* Use slices of the full output buffer for all other subgraph executions to avoid copies.
Add unit test to validate.
gramalingam
reviewed
Nov 26, 2018
gramalingam
previously approved these changes
Nov 26, 2018
gramalingam
approved these changes
Nov 26, 2018
skottmckay
deleted the
scmckay/SupportUnknownDimensionInScanSubgraphOutputs
branch
tmccrmck
pushed a commit
to tmccrmck/onnxruntime
that referenced
this pull request
Aug 28, 2019
…sult Fix random prediction results and replace camel-case names with snake-case names
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.