Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create suggestions to autofix files #22115

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Create suggestions to autofix files #22115

merged 3 commits into from
Oct 11, 2024

Conversation

justinchuby
Copy link
Contributor

No description provided.

@justinchuby justinchuby requested a review from a team as a code owner September 17, 2024 18:56
snnn
snnn previously approved these changes Sep 17, 2024
snnn
snnn previously approved these changes Sep 18, 2024
@justinchuby justinchuby marked this pull request as draft September 18, 2024 05:08
@skottmckay
Copy link
Contributor

Would be great to see in action. Could this PR have a temporary dummy change that triggers the auto correct suggestion?

@justinchuby
Copy link
Contributor Author

Currently there are two issues with this workflow: parkerbxyz/suggest-changes#36 and parkerbxyz/suggest-changes#37. I am waiting for a response from the repo maintainer

@justinchuby justinchuby marked this pull request as ready for review October 10, 2024 15:24
@justinchuby justinchuby marked this pull request as draft October 10, 2024 15:41
@justinchuby
Copy link
Contributor Author

@snnn could you reapprove? Thanks!

@justinchuby justinchuby added the merge on green This PR can be merged when the CI is green. Please merge. label Oct 11, 2024
@justinchuby justinchuby requested a review from snnn October 11, 2024 17:50
Copy link
Member

@snnn snnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@justinchuby justinchuby merged commit 64007ff into main Oct 11, 2024
87 of 88 checks passed
@justinchuby justinchuby deleted the justinchu/autofix branch October 11, 2024 17:52
guschmue pushed a commit that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge on green This PR can be merged when the CI is green. Please merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants