Remove empty (DQ -> Q -> graph output) sequence in TransposeOptimizer #22172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
onnxruntime/test/testdata/make_transpose_optimizer_empty_dq_q_at_output_model.py
Fixed
Show fixed
Hide fixed
adrianlizarraga
changed the title
adrianlizarraga
requested review from
edgchen1,
skottmckay,
jywu-msft and
HectorSVC
HectorSVC
previously approved these changes
Sep 24, 2024
skottmckay
previously approved these changes
Sep 24, 2024
onnxruntime/core/optimizer/transpose_optimization/onnx_transpose_optimization.cc
Outdated
Show resolved
Hide resolved
…se_optimization.cc Co-authored-by: Scott McKay <[email protected]>
adrianlizarraga
dismissed stale reviews from skottmckay and HectorSVC
via
f8cb77a
skottmckay
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the TransposeOptimizer to also remove empty (DQ -> Q) sequences that occur at a graph output. An empty DQ->Q sequence results from a Transpose being optimized out.
Consider the following example model:
The TransposeOptimizer removes the final Transpose and leaves an empty DQ->Q->output_0 sequence. This PR ensures that the final DQ->Q is also removed.
Motivation and Context
Models with quantized output can run on QNN EP. The inference latency of a customer model is impacted by the unnecessary DQ->Q sequence at the output.