Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade numpy requirement to 1.16.6 #3635

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Downgrade numpy requirement to 1.16.6 #3635

merged 1 commit into from
Apr 22, 2020

Conversation

snnn
Copy link
Member

@snnn snnn commented Apr 22, 2020

Description:

This PR is similar to #2758 except version number is changed to 1.16.6

Motivation and Context

  • Why is this change required? What problem does it solve?

Per suggestion from @jywu-msft and @guschmue :
1.18.0 was only released on Dec 22, 2019. Many users wouldn't like requiring such new software. and we don't even use numpy 1.18 specific api's in ORT.

See the discussion at #3003

  • If it fixes an open issue, please link to the issue here.

@snnn snnn requested a review from jywu-msft April 22, 2020 19:19
@snnn snnn requested a review from a team as a code owner April 22, 2020 19:19
@snnn snnn merged commit 0091791 into master Apr 22, 2020
@snnn snnn deleted the snnn/numpy branch April 22, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants