Workaround for MSVC linker bug #4713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. Is this bug documented somewhere? |
pranavsharma
approved these changes
Aug 6, 2020
thiagocrepaldi
approved these changes
Aug 6, 2020
Not that I know of. I don't have time to put together a full standalone example that replicates it to create a bug though as it could require lots of things to line up to repro. |
xkszltl
added a commit
to xkszltl/Roaster
that referenced
this pull request
Aug 10, 2020
xkszltl
added a commit
to xkszltl/Roaster
that referenced
this pull request
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Change order of some unit test checks to workaround a linker issue when /LTCG:incremental is set.
Motivation and Context
If std::isinf is prior to std::isnan the linker is omitting the isnan check. That leads to TensorOpTest.CastFromString failing as there are nan's in its expected results. Reversing the order of the checks avoids the linker bug.
#4623