Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Experimental WinRT API IDL as placeholder for adding new winrt features #4736

Merged
merged 8 commits into from
Aug 12, 2020

Conversation

smk2007
Copy link
Member

@smk2007 smk2007 commented Aug 7, 2020

Issue: There is no place to stage new WinRT APIs for consumption by redist callers.

Fix: Create a WinRT Experimental namespace where new features can be flighted and tested prior to addition to the official api.

winml/dll/module.cpp Outdated Show resolved Hide resolved
ryanlai2
ryanlai2 previously approved these changes Aug 7, 2020
@ryanlai2
Copy link
Contributor

ryanlai2 commented Aug 7, 2020

CPU CI is failing with this error : Could not open file 'C:\agent_work\1\b\Debug\onnxruntime.sln.log'

Copy link
Contributor

@ryanlai2 ryanlai2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@smk2007 smk2007 merged commit 8a66ad7 into master Aug 12, 2020
@smk2007 smk2007 deleted the user/sheilk/experimental-winrt-api branch August 12, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants