Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for diff input model types #82

Closed
wants to merge 7 commits into from

Conversation

jignparm
Copy link
Contributor

@jignparm jignparm commented Dec 4, 2018

Test the c# API with models of differing types

@jignparm jignparm requested a review from a team as a code owner December 4, 2018 01:12
var tensorOut = res.First().AsTensor<float>();
Assert.True(tensorOut.SequenceEqual(tensorIn));
}

[Fact]
private void Yunsong()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove this now?

shahasad
shahasad previously approved these changes Dec 4, 2018
Copy link
Member

@snnn snnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a PR in ONNX repo for testing int8/int16/... inputs.

onnx/onnx#1260

If that PR get merged, we can reuse it at here. Then most part of this PR is unnecessary.

snnn
snnn previously approved these changes Dec 4, 2018
@jignparm jignparm dismissed stale reviews from snnn and shahasad via daeb53b December 4, 2018 23:15
@jignparm jignparm closed this Dec 10, 2018
@jignparm
Copy link
Contributor Author

Abandoning -- added features in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants