Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failure on Jetpack 4.6 #8692

Closed
wants to merge 2 commits into from
Closed

Fix build failure on Jetpack 4.6 #8692

wants to merge 2 commits into from

Conversation

CoderHam
Copy link

Description:

Modify commit id of nlohmann/json to unblock jetpack 4.6 build for ORT 1.8.1

Motivation and Context

  • Why is this change required? What problem does it solve?

I was attempting a build with a specific commit (d14b08d) off master that enables TRT 8 support in ORT 1.8.1. This specific compilation issue is seen on a Jetson Xavier

In file included from /triton/onnxruntime/onnxruntime/test/providers/kernel_def_hash_test.cc:65:0:
/triton/onnxruntime/cmake/external/json/single_include/nlohmann/json.hpp: In member function ‘void nlohmann::detail::serializer<BasicJsonType>::dump_escaped(const string_t&, bool) [with BasicJsonType = nlohmann::basic_json<>]’:
/triton/onnxruntime/cmake/external/json/single_include/nlohmann/json.hpp:15817:10: error: ‘%.2X’ directive output may be truncated writing between 2 and 8 bytes into a region of size 3 [-Werror=format-truncation=]
     void dump_escaped(const string_t& s, const bool ensure_ascii)
          ^~~~~~~~~~~~
/triton/onnxruntime/cmake/external/json/single_include/nlohmann/json.hpp:15817:10: note: directive argument in the range [0, 2147483647]
In file included from /usr/include/stdio.h:862:0

This is required by Triton Inference Server for supporting the Onnxruntime backend on Jetson.
cc @askhade

@CoderHam CoderHam requested a review from a team as a code owner August 11, 2021 19:55
@@ -255,7 +255,7 @@
"component": {
"type": "git",
"git": {
"commitHash": "db78ac1d7716f56fc9f1b030b715f872f93964e4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just the manifest. but did you update the submodule itself?
i'm in the process of setting up a device with jetpack 4.6 to repro and validate.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the submodule as well

@ghost
Copy link

ghost commented Aug 11, 2021

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ CoderHam sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@snnn
Copy link
Member

snnn commented Aug 11, 2021

Let's hold on this. The new one is not released yet. @faxu and @pranavsharma may have concerns.

@jywu-msft
Copy link
Member

I made a PR for silencing the build warning, if we don't want to update the submodule to unreleased version.
#8701

@snnn snnn closed this Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compiler error: directive output may be truncated writing between 2 and 8 bytes
3 participants