Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of unnecessary "using namespace" from header files. #88

Closed
wants to merge 1 commit into from
Closed

Get rid of unnecessary "using namespace" from header files. #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions include/onnxruntime/core/framework/data_types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,8 +303,7 @@ class TensorType : public TensorTypeBase {

private:
TensorType() {
using namespace data_types_internal;
TensorContainedTypeSetter<elemT>::SetTensorElementType(this->mutable_type_proto());
data_types_internal::TensorContainedTypeSetter<elemT>::SetTensorElementType(this->mutable_type_proto());
}
};

Expand Down Expand Up @@ -390,8 +389,7 @@ class MapType : public NonTensorType<CPPType> {

private:
MapType() {
using namespace data_types_internal;
SetMapTypes<typename CPPType::key_type, typename CPPType::mapped_type>::Set(this->mutable_type_proto());
data_types_internal::SetMapTypes<typename CPPType::key_type, typename CPPType::mapped_type>::Set(this->mutable_type_proto());
}
};

Expand Down
1 change: 0 additions & 1 deletion onnxruntime/python/onnxruntime_pybind_mlvalue.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
#include "core/session/inference_session.h"


using namespace std;
namespace onnxruntime {
namespace python {

Expand Down
6 changes: 3 additions & 3 deletions onnxruntime/test/util/include/test/capturing_sink.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@
namespace onnxruntime {
namespace test {

using namespace ::onnxruntime::logging;

class CapturingSink : public logging::ISink {
public:
void SendImpl(const Timestamp& timestamp, const std::string& logger_id, const Capture& message) override {
void SendImpl(const ::onnxruntime::logging::Timestamp& timestamp,
const std::string& logger_id,
const ::onnxruntime::logging::Capture& message) override {
// operator for formatting of timestamp in ISO8601 format including microseconds
using date::operator<<;
std::ostringstream msg;
Expand Down