Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(#27117): fix: custom expect matchers on Locator/Page/APIResponse instance #27125

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

playwrightmachine
Copy link
Collaborator

This PR cherry-picks the following commits:

@github-actions
Copy link
Contributor

Test results for "tests 1"

9 flaky ⚠️ [chromium] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified
⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [playwright-test] › ui-mode-test-output.spec.ts:157:5 › should stream console messages live
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified
⚠️ [webkit] › page/page-goto.spec.ts:277:3 › should fail when navigating to bad SSL after redirects

25567 passed, 599 skipped
✔️✔️✔️

Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "tests 2"

56 failed
❌ [chromium] › page\page-click.spec.ts:979:3 › should click a button that is overlayed by a permission popup
❌ [chromium] › page/page-event-request.spec.ts:44:3 › should report requests and responses handled by service worker
❌ [chromium] › library\beforeunload.spec.ts:20:3 › should close browser with beforeunload page
❌ [chromium] › library\beforeunload.spec.ts:30:3 › should close browsercontext with beforeunload page
❌ [chromium] › library\beforeunload.spec.ts:38:3 › should be able to navigate away from page with beforeunload
❌ [chromium] › library\beforeunload.spec.ts:46:3 › should close page with beforeunload listener
❌ [chromium] › library\beforeunload.spec.ts:55:3 › should run beforeunload if asked for @smoke
❌ [chromium] › library\beforeunload.spec.ts:79:3 › should access page after beforeunload
❌ [chromium] › library\beforeunload.spec.ts:92:3 › should not stall on evaluate when dismissing beforeunload
❌ [chromium] › library\browser.spec.ts:19:5 › should return browserType
❌ [chromium] › library\browser.spec.ts:23:5 › should create new page @smoke
❌ [chromium] › library\browser.spec.ts:37:5 › should throw upon second create new page
❌ [chromium] › library\browser.spec.ts:45:5 › version should work
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:22:3 › should work @smoke
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:32:3 › should work with expires=-1
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:50:3 › should add cookies with empty value
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:68:3 › should roundtrip cookie
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:87:3 › should send cookie header
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:99:3 › should isolate cookies in browser contexts
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:115:3 › should isolate session cookies
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:141:3 › should isolate persistent cookies
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:161:3 › should isolate send cookie header
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:182:15 › should isolate cookies between launches
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:197:3 › should set multiple cookies
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:217:3 › should have |expires| set to |-1| for session cookies
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:227:3 › should set cookie with reasonable defaults
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:246:3 › should set a cookie with a path
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:272:3 › should not set a cookie with blank page URL
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:287:3 › should not set a cookie on a data URL page
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:297:3 › should default to setting secure cookie for HTTPS websites
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:309:3 › should be able to set unsecure cookie for HTTP website
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:321:3 › should set a cookie on a different domain
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:342:3 › should set cookies for a frame
❌ [chromium] › library\browsercontext-add-cookies.spec.ts:360:3 › should(not) block third party cookies
❌ [chromium] › library\browsercontext-add-init-script.spec.ts:20:3 › should work with browser context scripts @smoke
❌ [chromium] › library\browsercontext-add-init-script.spec.ts:28:3 › should work without navigation, after all bindings
❌ [chromium] › library\browsercontext-add-init-script.spec.ts:45:3 › should work without navigation in popup
❌ [chromium] › library\browsercontext-add-init-script.spec.ts:55:3 › should work with browser context scripts with a path
❌ [chromium] › library\browsercontext-add-init-script.spec.ts:62:3 › should work with browser context scripts for already created pages
❌ [chromium] › library\browsercontext-base-url.spec.ts:20:3 › should construct a new URL when a baseURL in browser.newContext is passed to page.goto @smoke
❌ [chromium] › library\browsercontext-base-url.spec.ts:29:3 › should construct a new URL when a baseURL in browser.newPage is passed to page.goto
❌ [chromium] › library\browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto
❌ [chromium] › library\browsercontext-base-url.spec.ts:47:3 › should construct the URLs correctly when a baseURL without a trailing slash in browser.newPage is passed to page.goto
❌ [chromium] › library\browsercontext-base-url.spec.ts:57:3 › should construct the URLs correctly when a baseURL with a trailing slash in browser.newPage is passed to page.goto
❌ [chromium] › library\browsercontext-base-url.spec.ts:69:3 › should not construct a new URL when valid URLs are passed
❌ [chromium] › library\browsercontext-base-url.spec.ts:83:3 › should be able to match a URL relative to its given URL with urlMatcher
❌ [chromium] › library\browsercontext-base-url.spec.ts:105:3 › should not construct a new URL with baseURL when a glob was used
❌ [chromium] › library\browsercontext-basic.spec.ts:21:3 › should create new context @smoke
❌ [chromium] › library\browsercontext-basic.spec.ts:32:3 › window.open should use parent tab context
❌ [chromium] › library\browsercontext-basic.spec.ts:44:3 › should isolate localStorage and cookies @smoke
❌ [chromium] › library\browsercontext-basic.spec.ts:89:3 › should propagate default viewport to the page
❌ [chromium] › library\browsercontext-basic.spec.ts:96:3 › should make a copy of default viewport
❌ [chromium] › page\page-leaks.spec.ts:123:5 › expect should not leak
❌ [chromium] › library/emulation-focus.spec.ts:104:3 › should not affect screenshots
❌ [chromium] › library/video.spec.ts:429:5 › screencast › should scale frames down to the requested size
❌ [chromium] › library/trace-viewer.spec.ts:1038:1 › should highlight locator in iframe while typing

100 flaky ⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library\tracing.spec.ts:469:5 › should work with multiple chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:395:14 › should produce screencast frames crop
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/browsercontext-proxy.spec.ts:322:3 › should exclude patterns
⚠️ [chromium] › library/inspector/cli-codegen-1.spec.ts:196:7 › cli codegen › should not target selector preview by text regexp
⚠️ [chromium] › library/inspector/cli-codegen-3.spec.ts:479:7 › cli codegen › should generate getByLabel without regex
⚠️ [chromium] › library/trace-viewer.spec.ts:1038:1 › should highlight locator in iframe while typing
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-drag.spec.ts:53:5 › Drag and drop › should not send dragover on the first mousemove
⚠️ [chromium] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [chromium] › library/browsercontext-proxy.spec.ts:322:3 › should exclude patterns
⚠️ [chromium] › library/trace-viewer.spec.ts:1038:1 › should highlight locator in iframe while typing
⚠️ [chromium] › page/page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [chromium] › page/page-drag.spec.ts:330:5 › Drag and drop › should work with locators
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:469:5 › should work with multiple chunks
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › library/chromium/launcher.spec.ts:102:3 › should support request/response events when using backgroundPage()
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-close.spec.ts:29:3 › should not accept after close
⚠️ [chromium] › page/page-event-popup.spec.ts:61:3 › should be able to capture alert
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library\tracing.spec.ts:469:5 › should work with multiple chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:130:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium] › library/chromium/oopif.spec.ts:259:3 › ElementHandle.boundingBox() should work
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/inspector/cli-codegen-pytest.spec.ts:56:5 › should save the codegen output to a file if specified
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library\chromium\launcher.spec.ts:102:3 › should support request/response events when using backgroundPage()
⚠️ [firefox] › page/page-request-continue.spec.ts:271:3 › should work with Cross-Origin-Opener-Policy
⚠️ [firefox] › library/browsercontext-har.spec.ts:144:3 › should change document URL after redirected navigation
⚠️ [firefox] › page/page-event-request.spec.ts:162:3 › should return response body when Cross-Origin-Opener-Policy is set
⚠️ [firefox] › library\browsertype-connect.spec.ts:383:5 › launchServer › should terminate network waiters
⚠️ [firefox] › library\signals.spec.ts:25:5 › should close the browser when the node process closes
⚠️ [firefox] › library/capabilities.spec.ts:256:3 › requestFullscreen
⚠️ [firefox] › library/trace-viewer.spec.ts:1000:1 › should pick locator in iframe
⚠️ [firefox] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox] › library/video.spec.ts:189:5 › screencast › should capture static page
⚠️ [firefox] › library/video.spec.ts:712:5 › screencast › should capture full viewport on hidpi
⚠️ [firefox] › library\browsercontext-service-worker-policy.spec.ts:18:3 › should allow service workers by default
⚠️ [firefox] › library\download.spec.ts:105:5 › download event › should report downloads with acceptDownloads: false
⚠️ [firefox] › library\download.spec.ts:341:5 › download event › should delete file
⚠️ [firefox] › library\permissions.spec.ts:103:5 › permissions › should trigger permission onchange
⚠️ [firefox] › library\trace-viewer.spec.ts:88:1 › should open two trace viewers
⚠️ [firefox] › page\page-add-script-tag.spec.ts:93:3 › should throw when added with content to the CSP page
⚠️ [firefox] › page\page-click-timeout-4.spec.ts:20:3 › should timeout waiting for stable position
⚠️ [firefox] › library/browsercontext-har.spec.ts:144:3 › should change document URL after redirected navigation
⚠️ [firefox] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [firefox] › library\proxy.spec.ts:179:3 › should exclude patterns
⚠️ [firefox] › page\page-screenshot.spec.ts:641:5 › page screenshot animations › should not capture infinite web animations
⚠️ [chromium] › library/capabilities.spec.ts:139:3 › should not crash on showDirectoryPicker
⚠️ [chromium] › library/inspector/cli-codegen-test.spec.ts:88:5 › should work with --save-har
⚠️ [chromium] › library/beforeunload.spec.ts:92:3 › should not stall on evaluate when dismissing beforeunload
⚠️ [chromium] › library/fetch-proxy.spec.ts:30:3 › context request should pick up proxy credentials
⚠️ [chromium] › page/page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [chromium] › page/page-mouse.spec.ts:147:3 › should select the text with mouse
⚠️ [chromium] › library\browsertype-launch-server.spec.ts:56:5 › launch server › should provide an error when ws endpoint is incorrect
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library\tracing.spec.ts:469:5 › should work with multiple chunks
⚠️ [chromium] › page\page-set-input-files.spec.ts:40:3 › should upload large file
⚠️ [chromium] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library\tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/proxy.spec.ts:179:3 › should exclude patterns
⚠️ [webkit] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified
⚠️ [webkit] › page/page-goto.spec.ts:277:3 › should fail when navigating to bad SSL after redirects
⚠️ [webkit] › page/page-wait-for-navigation.spec.ts:85:3 › should work with clicking on links which do not commit navigation
⚠️ [webkit] › library/inspector/cli-codegen-3.spec.ts:479:7 › cli codegen › should generate getByLabel without regex
⚠️ [webkit] › page/page-request-fallback.spec.ts:239:5 › post data › should amend binary post data
⚠️ [webkit] › page/selectors-vue.spec.ts:51:7 › vue2 › should not crash when there is no match
⚠️ [webkit] › library/inspector/cli-codegen-1.spec.ts:625:7 › cli codegen › should await popup
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [webkit] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context
⚠️ [webkit] › library/trace-viewer.spec.ts:1038:1 › should highlight locator in iframe while typing
⚠️ [webkit] › page/page-drag.spec.ts:260:5 › Drag and drop › should be able to drag the mouse in a frame
⚠️ [webkit] › page/page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [webkit] › page/page-wait-for-navigation.spec.ts:85:3 › should work with clicking on links which do not commit navigation
⚠️ [webkit] › library\browsercontext-viewport-mobile.spec.ts:58:5 › mobile viewport › should be detectable by Modernizr
⚠️ [webkit] › library\browsercontext-viewport.spec.ts:94:3 › should not have touch by default
⚠️ [webkit] › library\browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [webkit] › library\har.spec.ts:424:3 › should return receive time
⚠️ [webkit] › library\inspector\cli-codegen-1.spec.ts:158:7 › cli codegen › should work with TrustedTypes
⚠️ [webkit] › library\inspector\cli-codegen-1.spec.ts:520:7 › cli codegen › should uncheck
⚠️ [webkit] › library\inspector\cli-codegen-3.spec.ts:392:7 › cli codegen › should generate getByPlaceholder
⚠️ [webkit] › library\inspector\cli-codegen-3.spec.ts:479:7 › cli codegen › should generate getByLabel without regex
⚠️ [webkit] › library\tap.spec.ts:23:3 › should send all of the correct events @smoke
⚠️ [webkit] › library\tracing.spec.ts:469:5 › should work with multiple chunks
⚠️ [webkit] › page\page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [webkit] › page\page-drag.spec.ts:289:5 › Drag and drop › should work with the helper method
⚠️ [webkit] › page\page-drag.spec.ts:330:5 › Drag and drop › should work with locators
⚠️ [webkit] › page/page-request-continue.spec.ts:177:5 › post data › should compute content-length from post data
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
100 interrupted ⚠️ [chromium] › library\browsercontext-basic.spec.ts:105:3 › should respect deviceScaleFactor

177684 passed, 11180 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit 6cc43d8 into release-1.38 Sep 15, 2023
90 of 97 checks passed
@mxschmitt mxschmitt deleted the cherry-pick-1.38-2023-09-15-16-06-32 branch September 15, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants