fix(trace viewer): library-only trace should not merge actions #31768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without `wallTime`, actions are matched by `actionName:undefined` and all actions with the same are merged.
Test results for "tests 1"7 flaky23939 passed, 616 skipped Merge workflow run. |
yury-s
approved these changes
Jul 19, 2024
I understand that actions with same timestamp would be merged, but why do we have actions without Update: I see, in the new traces there is no wallTime, only stepId! |
yury-s
pushed a commit
to yury-s/playwright
that referenced
this pull request
Jul 20, 2024
…hould not merge actions Without `wallTime`, actions are matched by `actionName:undefined` and all actions with the same are merged. Fixes microsoft#31764.
yury-s
pushed a commit
to yury-s/playwright
that referenced
this pull request
Jul 22, 2024
…hould not merge actions Without `wallTime`, actions are matched by `actionName:undefined` and all actions with the same are merged. Fixes microsoft#31764.
yury-s
added a commit
that referenced
this pull request
Jul 22, 2024
… merge actions (#31780) This PR cherry-picks two trace viewer fixes: cherry-pick(#31768): fix(trace viewer): library-only trace should not merge actions cherry-pick(#31564): fix(trace): do not corrupt test runner actions when no library trace is present Reference: microsoft/playwright-java#1617
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without
wallTime, actions are matched byactionName:undefinedand all actions with the same are merged.Fixes #31764.