Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unify toHaveScreenshot error formatting #33300

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Oct 25, 2024

  • Changed error header to align with other expect matchers
  • Prepend timeout error message same way as in other matchers

New message:

image

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

3 flaky ⚠️ [playwright-test] › ui-mode-test-ct.spec.ts:215:5 › should watch component via util @ubuntu-latest-node20-1
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:206:5 › mobile viewport › view scale should reset after navigation @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

36675 passed, 626 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants