fix(aria snapshot): assorted fixes #33512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
pavelfeldman
approved these changes
Nov 8, 2024
| @@ -579,3 +619,34 @@ test('call log should contain actual snapshot', async ({ page }) => { | |||
|
|
|||
| expect(stripAnsi(error.message)).toContain(`- unexpected value "- heading "todos" [level=1]"`); | |||
| }); | |||
|
|
|||
| test.fixme('should normalize whitespace when matching accessible name', async ({ page }) => { | |||
| `); | ||
| }); | ||
|
|
||
| it.fixme('should handle long strings', async ({ page }) => { |
- RegExp parsing - text value escaping - limit string lengths in `longestCommonSubstring` - failing tests for unresolved edge cases
dgozman
force-pushed
the
aria-snapshot-fixes
branch
from
a3778b5
to
742a908
Compare
Test results for "tests 1"2 fatal errors, not part of any test 1 flaky1 interrupted36839 passed, 690 skipped, 24 did not run Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
longestCommonSubstring