fix(test-runner): add jest-matcher-utils to dependencies #8501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's lint this:
Looks like check_deps just needs a few lines to make this all happen. |
|
There is a ESLint plugin to deal with linting this https://github.com/import-js/eslint-plugin-import/blob/49ada27a495899d0247bc9661ed0f055e970fe3b/docs/rules/no-extraneous-dependencies.md |
mxschmitt
force-pushed
the
bugfix-add-jest-matcher-utils
branch
2 times, most recently
from
b9a8f27
to
1bbae1f
Compare
mxschmitt
force-pushed
the
bugfix-add-jest-matcher-utils
branch
from
1bbae1f
to
32dd6c7
Compare
pavelfeldman
approved these changes
Sep 2, 2021
mrienstra
added a commit
to mrienstra/jest
that referenced
this pull request
Sep 5, 2021
The `playwright` repo uses `expect`, I'd like to bump the version they're using from `26.4.2` to `27.1.0`. Here is the issue which motivated this change: jestjs#11640 You can see my proposed changes here: microsoft/playwright@master...mrienstra:patch-3 I haven't opened a PR for those changes yet, hoping to land this one first. Playwright `npm check-deps` runs `utils/check_deps.js`, which contains a function `allowExternalImport` / `alllowExternalImport` (very recently added in microsoft/playwright#8501), which has a problem with the `expect` `package.json` `exports`, thus the motivation for this PR.
This was referenced Sep 5, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8495