Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Key recognizer #1339

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

Nweaver412
Copy link

@Nweaver412 Nweaver412 commented Mar 20, 2024

Change Description

Added API token Recognizer

Issue reference

This PR fixes issue #XX

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@Nweaver412
Copy link
Author

@microsoft-github-policy-service agree

@omri374
Copy link
Contributor

omri374 commented Mar 20, 2024

Thanks, great addition! Can you please add a few unit tests?

@Nweaver412
Copy link
Author

Thanks, great addition! Can you please add a few unit tests?

Added a few, let me know if they should be more comprehensive, thanks!

return super().analyze(text)


class TestAPIKeyRecognizer(unittest.TestCase):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the test to a new file under /tests. See many examples of other recognizers. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants