There will be no normal chat_with_pdf_custom_connection any more

microsoft · Aug 22, 2023 · 7eb2db4 · 7eb2db4
1 parent 053bb01
commit 7eb2db4
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 6 deletions.
diff --git a/.github/workflows/samples_flows_chat_chat_with_pdf.yml b/.github/workflows/samples_flows_chat_chat_with_pdf.yml
@@ -51,7 +51,7 @@ jobs:
         working-directory: examples/flows/chat/chat-with-pdf
         run: |
           if [[ -e .env ]]; then
-            pf connection create --file .env --name chat_with_pdf_custom_connection
+            pf connection create --file .env --name azure_open_ai_connection
             pf connection list
           fi
           

diff --git a/.github/workflows/samples_flows_chat_chatwithpdf_chatwithpdf.yml b/.github/workflows/samples_flows_chat_chatwithpdf_chatwithpdf.yml
@@ -44,7 +44,7 @@ jobs:
             echo "env replacement"
             sed -i -e "s/<your_AOAI_key>/$AOAI_API_KEY/g" -e "s/<your_AOAI_endpoint>/$AOAI_API_ENDPOINT/g" .env.example
             mv .env.example .env
-            pf connection create --file .env --name chat_with_pdf_custom_connection
+            pf connection create --file .env --name azure_open_ai_connection
           fi
       - name: Azure Login
         uses: azure/login@v1

diff --git a/.github/workflows/samples_tutorials_e2e_development_chat_with_pdf.yml b/.github/workflows/samples_tutorials_e2e_development_chat_with_pdf.yml
@@ -51,7 +51,7 @@ jobs:
         working-directory: examples/tutorials/e2e-development
         run: |
           if [[ -e .env ]]; then
-            pf connection create --file .env --name chat_with_pdf_custom_connection
+            pf connection create --file .env --name azure_open_ai_connection
             pf connection list
           fi
           

diff --git a/examples/flows/chat/chat-with-pdf/chat-with-pdf.ipynb b/examples/flows/chat/chat-with-pdf/chat-with-pdf.ipynb
@@ -56,6 +56,7 @@
    "source": [
     "# create needed connection\n",
     "from promptflow.entities import AzureOpenAIConnection\n",
+    "\n",
     "try:\n",
     "    conn_name = \"azure_open_ai_connection\"\n",
     "    conn = pf.connections.get(name=conn_name)\n",
@@ -128,7 +129,7 @@
     "    \"CHUNK_OVERLAP\": 32,\n",
     "}\n",
     "\n",
-    "column_mapping={\n",
+    "column_mapping = {\n",
     "    \"question\": \"${data.question}\",\n",
     "    \"pdf_url\": \"${data.pdf_url}\",\n",
     "    \"chat_history\": \"${data.chat_history}\",\n",

diff --git a/scripts/readme/ghactions_driver/readme_workflow_generate.py b/scripts/readme/ghactions_driver/readme_workflow_generate.py
@@ -31,7 +31,7 @@ def write_readme_workflow(readme_path, output_telemetry=Telemetry()):
     ReadmeSteps.install_dev_dependencies()
     ReadmeSteps.create_env()
     if workflow_name.endswith("pdf"):
-        ReadmeSteps.env_create_aoai("chat_with_pdf_custom_connection")
+        ReadmeSteps.env_create_aoai("azure_open_ai_connection")
     ReadmeSteps.create_run_yaml()
     if (
         workflow_name.endswith("flows_standard_basic_with_builtin_llm")

diff --git a/scripts/readme/ghactions_driver/workflow_templates/pdf_workflow.yml.jinja2 b/scripts/readme/ghactions_driver/workflow_templates/pdf_workflow.yml.jinja2
@@ -30,7 +30,7 @@ steps:
         echo "env replacement"
         sed -i -e "s/<your_AOAI_key>/$AOAI_API_KEY/g" -e "s/<your_AOAI_endpoint>/$AOAI_API_ENDPOINT/g" .env.example
         mv .env.example .env
-        pf connection create --file .env --name chat_with_pdf_custom_connection
+        pf connection create --file .env --name azure_open_ai_connection
       fi
   - name: Azure Login
     uses: azure/login@v1