fix unittest in gcc13

[coyorkdow]

GCC13 added a new warning Wself-move (regarding info https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81159). Therefore, the relevant codes in unittest will throw errors as -Werror is opened.

Add a diagnostic pragma to remove the errors.

[mingxwa]

Thank you for reporting the issue and proposing the fix! Please refer to the inline comments.

In addition, since this one should repro in GCC 13 while our pipeline is running the tests against GCC 11, we appreciate your help if you could help update the pipeline to use GCC 13 by default, or file an issue to track this if you are not familiar with GitHub Actions.

[coyorkdow]

@microsoft-github-policy-service agree

[coyorkdow]

Thank you for reporting the issue and proposing the fix! Please refer to the inline comments.

In addition, since this one should repro in GCC 13 while our pipeline is running the tests against GCC 11, we appreciate your help if you could help update the pipeline to use GCC 13 by default, or file an issue to track this if you are not familiar with GitHub Actions.

A new commit is appened to this MR to update the ci to gcc-13. plz review it :)

[coyorkdow]

@mingxwa

Nit: Since the lines above looks similar to the new block, can we merge them to make the block shorter?

I found that it seems clang is compatiable with #pragma GCC, so we can simply use same pragma for both clang and gcc.

#if defined(__clang__) || (defined(__GNUC__) && __GNUC__ >= 13)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wself-move"
#endif
    p = std::move(p);
#if defined(__clang__) || (defined(__GNUC__) && __GNUC__ >= 13)
#pragma GCC diagnostic pop
#endif

But I am not sure if it will affect the portability.

[mingxwa]

LGTM

[coyorkdow]

Should we merge the pragmas of clang and gcc or just keep them unchanged? @mingxwa

[coyorkdow]

@mingxwa Hi. Can it be merged?

[mingxwa]

@coyorkdow Sorry for the delayed reply. Given that -Wself-move is the only overlap between clang and GCC for now (and GCC requires a version), I suggest checking-in as-is. If there are more overlaps in the future, we can refactor in a separate PR.

[coyorkdow]

@mingxwa Got it. Does this PR is already to merge? Or any modification do I need to do?