Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move sim to optional dependencies #699

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Move sim to optional dependencies #699

merged 1 commit into from
Jan 31, 2019

Conversation

guillaumejenkins
Copy link
Contributor

Addresses #698

@pelikhan
Copy link
Member

is the build pushing to npm?

@guillaumejenkins
Copy link
Contributor Author

The build is not pushing to NPM; I believe for that we need to add the npm token to Travis

@guillaumejenkins guillaumejenkins merged commit 49d47e7 into master Jan 31, 2019
@guillaumejenkins guillaumejenkins deleted the optionalSim branch January 31, 2019 17:17
@iaroslavn iaroslavn mentioned this pull request Jan 31, 2019
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pelikhan pelikhan pelikhan approved these changes

@riknoll riknoll Awaiting requested review from riknoll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guillaumejenkins @pelikhan