Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Expression value is unused" should not be reported for last expression in notebook cell #3282

Closed
matangover opened this issue Sep 4, 2022 · 3 comments
Closed

"Expression value is unused" should not be reported for last expression in notebook cell #3282

matangover opened this issue Sep 4, 2022 · 3 comments
Assignees
@debonte
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version notebooks

Comments

@matangover
Copy link

Jupyter notebook uses the last expression in each cell as the cell's output. Hence, it should not be reported as unused.
@judej judej added the needs investigation Could be an issue - needs investigation label Sep 6, 2022
@debonte debonte self-assigned this Sep 6, 2022
@debonte debonte added notebooks bug Something isn't working and removed needs investigation Could be an issue - needs investigation labels Sep 6, 2022
@debonte debonte mentioned this issue Nov 8, 2022
Merged
@debonte debonte added the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label Nov 11, 2022
@rchiodo rchiodo closed this as completed Nov 17, 2022
@rchiodo
Copy link
Contributor

rchiodo commented Nov 17, 2022

This issue has been fixed in prerelease version 2022.11.31, which we've just released. You can find the changelog here: CHANGELOG.md

This was referenced Nov 18, 2022
Closed
Closed
@alecglen
Copy link

alecglen commented Dec 1, 2022

I am still seeing this behavior in v2022.11.40 and v2022.11.41 (pre-release).

@rchiodo
Copy link
Contributor

rchiodo commented Dec 1, 2022 •
edited
Loading

What's your version of the jupyter extension? It may be providing its own errors in this situation if it's not the latest prerelease for jupyter too. (I ran into this problem too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@debonte debonte

Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version notebooks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@judej @matangover @debonte @rchiodo @alecglen