"Expression value is unused" should not be reported for last expression in notebook cell #4164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
reviewed
Nov 8, 2022
rchiodo
approved these changes
Nov 8, 2022
debonte
commented
Nov 8, 2022
rchiodo
approved these changes
Nov 8, 2022
heejaechang
reviewed
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address microsoft/pylance-release#3282
Don't report an error for an unused expression at the end of a notebook cell, as it is treated as the cell's value.
The tests are checking the diagnostic count which we would normally do by testing a sample
.pyfile, but I don't believe we have a way to enableipythonModewith that approach. If you'd prefer the tests to work that way, I can look into making that work.