Added error handling for very large source files. This situation is n… #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow detected earlier so we don't attempt to load the file contents and crash the language server in the process.
jakebailey
reviewed
Jun 10, 2021
| @@ -520,6 +524,15 @@ export class SourceFile { | |||
| let fileContents = this.getFileContents(); | |||
| if (fileContents === undefined) { | |||
| try { | |||
| const fileStat = this.fileSystem.statSync(this._filePath); | |||
There was a problem hiding this comment.
Can you move this section down into the timeOperation below? That way, we'll count the time it takes to stat in addition to the read itself and not have unaccounted time.
…as part of the file read operation.
jakebailey
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ow detected earlier so we don't attempt to load the file contents and crash the language server in the process.