[docs][ios] readme: improved “Multi-Deployment Testing” chapter for iOS #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sergey-akhalkov, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
sergey-akhalkov
changed the title
richardhuaaa
approved these changes
Feb 8, 2017
| @@ -700,17 +700,21 @@ To set this up, perform the following steps: | |||
|
|
|||
| 6. Select the `Build Settings` tab | |||
|
|
|||
| 7. Click the `+` button on the toolbar and select `Add User-Defined Setting` | |||
| 7. Go to `Build Location -> Per-configuration Build Products Path -> Staging` and change `Staging` value from `$(BUILD_DIR)/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)` to `$(BUILD_DIR)/Release$(EFFECTIVE_PLATFORM_NAME)` | |||
There was a problem hiding this comment.
Could you leave a short note here explaining why? (Similar to your PR description, with a link)
After RN 0.40 it is not possible to use other configurations than Debug and Release (facebook/react-native#11813) As workaround we could make Staging’s Build Products Path value the same as for Release configuration. Fix #688
|
Fixed it, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After RN 0.40 it is not possible to use other configurations than Debug and Release facebook/react-native#11813
As workaround we could make Staging’s Build Products Path value the same as for Release configuration.
Fix #688