fix tree api being called twice on initial load due to uninitialized …

…context being used (#1229)
microsoft · Feb 27, 2022 · 68ac41d · 68ac41d
1 parent f6204fb
commit 68ac41d
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/...or-analysis/src/lib/ErrorAnalysisDashboard/Controls/TreeViewRenderer/TreeViewRenderer.tsx b/...or-analysis/src/lib/ErrorAnalysisDashboard/Controls/TreeViewRenderer/TreeViewRenderer.tsx
@@ -12,7 +12,8 @@ import {
   MetricCohortStats,
   ModelAssessmentContext,
   defaultModelAssessmentContext,
-  IErrorAnalysisTreeNode
+  IErrorAnalysisTreeNode,
+  IModelAssessmentContext
 } from "@responsible-ai/core-ui";
 import { localization } from "@responsible-ai/localization";
 import { Property } from "csstype";
@@ -80,15 +81,18 @@ export class TreeViewRenderer extends React.PureComponent<
   private static saveStateOnUnmount = true;
   public context: React.ContextType<typeof ModelAssessmentContext> =
     defaultModelAssessmentContext;
-  public constructor(props: ITreeViewRendererProps) {
+  public constructor(
+    props: ITreeViewRendererProps,
+    context: IModelAssessmentContext
+  ) {
     super(props);
     if (
       this.props.selectedCohort !== this.props.baseCohort &&
       TreeViewRenderer.savedState
     ) {
       this.state = TreeViewRenderer.savedState;
     } else {
-      this.state = createInitialTreeViewState(this.context.errorAnalysisData);
+      this.state = createInitialTreeViewState(context.errorAnalysisData);
     }
     TreeViewRenderer.saveStateOnUnmount = true;
   }