Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dnn notebook example to give more interesting results #1194

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

imatiach-msft
Copy link
Contributor

@imatiach-msft imatiach-msft commented Feb 1, 2022

Description

The notebook "notebooks/responsibleaidashboard/responsibleaidashboard-multiclass-dnn-model-debugging.ipynb" had a DNN pytorch model that was only trained for 12 epochs, which ended up giving the same result during inference.
This PR updates the dnn notebook example to train the model for 10000 epochs, to give more interesting results.
Although it takes 13 seconds to train the model, instead of making training instantaneous, the model outputs several possible classes instead of just one class.

Areas changed

npm packages changed:

  • responsibleai/causality
  • responsibleai/core-ui
  • responsibleai/counterfactuals
  • responsibleai/dataset-explorer
  • responsibleai/fairness
  • responsibleai/interpret
  • responsibleai/localization
  • responsibleai/mlchartlib
  • responsibleai/model-assessment

Python packages changed:

  • raiwidgets
  • responsibleai
  • erroranalysis
  • rai_core_flask

Tests

  • No new tests required.
  • New tests for the added feature are part of this PR.
  • I validated the changes manually.

Screenshots (if appropriate):

Model overview after increasing the number of iterations in the sample notebook:
image

Previously it would just be:
image

Documentation:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2022

Codecov Report

Merging #1194 (15c900b) into main (7c6b2a4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1194   +/-   ##
=======================================
  Coverage   67.76%   67.76%           
=======================================
  Files          90       90           
  Lines        4291     4291           
=======================================
  Hits         2908     2908           
  Misses       1383     1383           
Flag Coverage Δ
unittests 67.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c6b2a4...15c900b. Read the comment docs.

@imatiach-msft imatiach-msft merged commit dab0f71 into main Feb 1, 2022
@imatiach-msft imatiach-msft deleted the ilmat/update-dnn-nb branch February 1, 2022 22:14
gaugup added a commit that referenced this pull request Feb 7, 2022
* Add cohort and filter definitions in raiwidgets SDK

Signed-off-by: Gaurav Gupta <[email protected]>

* Remove commented out code

Signed-off-by: Gaurav Gupta <[email protected]>

* Add metrics to StatisticsUtils - F1 score, selection rate, mean absolute error (#1174)

* add new metrics

* undo unwanted changes

* fix casing

* add superscript 2 for r-squared

* update tests to reflect new metrics

* lintfix

* fix mae calculation

* update dnn notebook example to give more interesting results (#1194)

* Add upload step to e2e test workflow (#1183)

* update config

* update cypress config

* Add upload step to e2e test to CI notebooks pipeline (#1188)

* changes

* lintfix

* Fix code review comments

Signed-off-by: Gaurav Gupta <[email protected]>

Co-authored-by: Roman Lutz <[email protected]>
Co-authored-by: Ilya Matiach <[email protected]>
Co-authored-by: Vinutha Karanth <[email protected]>
gaugup added a commit that referenced this pull request Feb 27, 2022
* Add cohort and filter definitions in raiwidgets SDK

Signed-off-by: Gaurav Gupta <[email protected]>

* Remove commented out code

Signed-off-by: Gaurav Gupta <[email protected]>

* Add metrics to StatisticsUtils - F1 score, selection rate, mean absolute error (#1174)

* add new metrics

* undo unwanted changes

* fix casing

* add superscript 2 for r-squared

* update tests to reflect new metrics

* lintfix

* fix mae calculation

* update dnn notebook example to give more interesting results (#1194)

* Add upload step to e2e test workflow (#1183)

* update config

* update cypress config

* Add upload step to e2e test to CI notebooks pipeline (#1188)

* changes

* lintfix

* Fix code review comments

Signed-off-by: Gaurav Gupta <[email protected]>

Co-authored-by: Roman Lutz <[email protected]>
Co-authored-by: Ilya Matiach <[email protected]>
Co-authored-by: Vinutha Karanth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants