Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable highchart exporting functionality #1204

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Conversation

zhb000
Copy link
Contributor

@zhb000 zhb000 commented Feb 7, 2022

Enable highchart exporting functionality

Areas changed

npm packages changed:

  • responsibleai/causality
  • responsibleai/core-ui
  • responsibleai/counterfactuals
  • responsibleai/dataset-explorer
  • responsibleai/fairness
  • responsibleai/interpret
  • responsibleai/localization
  • responsibleai/mlchartlib
  • responsibleai/model-assessment

Python packages changed:

  • raiwidgets
  • responsibleai
  • erroranalysis
  • rai_core_flask

Tests

  • No new tests required.
  • New tests for the added feature are part of this PR.
  • I validated the changes manually.

Screenshots (if appropriate):

Documentation:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #1204 (003baac) into main (c3cb6e2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1204   +/-   ##
=======================================
  Coverage   66.85%   66.85%           
=======================================
  Files          91       91           
  Lines        4350     4350           
=======================================
  Hits         2908     2908           
  Misses       1442     1442           
Flag Coverage Δ
unittests 66.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3cb6e2...003baac. Read the comment docs.

Copy link
Contributor

@imatiach-msft imatiach-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome!

@zhb000 zhb000 enabled auto-merge (squash) February 8, 2022 02:57
@zhb000 zhb000 merged commit 42bfb10 into main Feb 8, 2022
@zhb000 zhb000 deleted the zhb/HighchartExporting branch February 8, 2022 04:30
gaugup pushed a commit that referenced this pull request Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants